[PATCH] D37709: [LLD] [COFF] Add support for the -wholearchive option

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: COFF/Driver.cpp:131
+
+      for (MemoryBufferRef Member : getArchiveMembers(File.get()))
+        addArchiveBuffer(Member, "*", MBRef.getBufferIdentifier());
----------------
nit: I'd rename Member M.


================
Comment at: COFF/Driver.cpp:132
+      for (MemoryBufferRef Member : getArchiveMembers(File.get()))
+        addArchiveBuffer(Member, "*", MBRef.getBufferIdentifier());
+      return;
----------------
Instead of "*", let's pass something like "<whole-archive>" instead.


https://reviews.llvm.org/D37709