[PATCH] D37709: [MinGW] Add support for the options --[no-]whole-archive

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D37709#868490, @ruiu wrote:

> Could you split this patch into two, one for COFF and one for MinGW?


Sure, will repost with it split, and with your suggestions applied.



================
Comment at: COFF/Driver.cpp:135
+    }
     return Symtab->addFile(make<ArchiveFile>(MBRef));
+  }
----------------
ruiu wrote:
> It's not new code, but can you write it in two lines?
> 
>   Symtab->addFile(make<ArchiveFile>(MBRef));
>   return;
> 
> Because `addFile` returns void and this function returns void too, it is legal to write `return Symtab->addFile(...)`, but this is still an odd feature of C++, and I believe we generally want to avoid this unless it's generated as instantiated templates.
Sure, I can fix that at the same time.


https://reviews.llvm.org/D37709