[PATCH] D37753: [AMDGPU] implemented pal metadata

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 12:57:52 PDT 2017


t-tye added a comment.

For HSA the ABI version is used to version the overall code object and no separate not record is used. Hor HSA the metadata note record contains a version attribute that indicates the metadata version.

For PAL what is the AMDGPU_PAL_CODE_OBJECT_VERSION .note record versioning? Is it the overall code object: if so can the same approach as HSA be used; if the metadata then suggest moving the version inside the metadata note record itself so it is self describing.


https://reviews.llvm.org/D37753





More information about the llvm-commits mailing list