[PATCH] D37724: [ARM] Add more CPUs to host detection

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls accepted this revision.
kristof.beyls added inline comments.
This revision is now accepted and ready to land.


================
Comment at: unittests/Support/Host.cpp:108-110
+  EXPECT_EQ(sys::detail::getHostCPUNameForARM("CPU implementer : 0x51\n"
+                                              "CPU part        : 0x800"),
+            "cortex-a73");
----------------
efriedma wrote:
> kristof.beyls wrote:
> > I don't have easy access to a Cortex-A73 system at the moment, but I'd expect the CPU implementer for a Cortex-A73 be 0x41, the same as for other Arm-designed cores.
> > Also, according to http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.100048_0002_05_en/jfa1406793219362.html, the part number of Cortex-A73 is 0xD09, not 0x800.
> Kryo second-generation is not a Cortex-A73. It's just close enough from the compiler's perspective that it isn't worth distinguishing here.  (getHostCPUNameForARM already has separate detection code for actual A73 CPUs.)
ah - apologies, I didn't look at enough context code of this change.
I was confused by adding 2 "CPU parts" 0x800 and 0x801 both mapping to Cortex-A73, and didn't catch that both represent second-generation Kryo cores.
It now makes sense to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D37724