[PATCH] D37617: Debug info for variables whose type is shrinked to bool fix

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Transforms/IPO/GlobalOpt.cpp:1625
+        DIExpression *E = GVe->getExpression();
+
+        // val * (ValOther - ValInit) + ValInit:
----------------
Since this is bound to confuse future readers, it wouldn't hurt to add a line explaining how this expression works.


================
Comment at: lib/Transforms/IPO/GlobalOpt.cpp:1648
+     // FIXME: This will only emit address for debugger on which will
+     // be written only 0 or 1.
+     for(auto *GV : GVs)
----------------
Why this restriction?


https://reviews.llvm.org/D37617