[PATCH] D37740: [SelectionDAG] Pick correct frame index in LowerArguments

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8802
+      // We want to find the highest frame index involved here (associating
+      // the argument with the lowest stack address involved). The
+      // getCopyFromParts call above is swapping the order of the operands to
----------------
Always the highest or does this depend on the direction in which the stack grows?


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8811
       if (LoadSDNode *LNode =
-          dyn_cast<LoadSDNode>(Res.getOperand(0).getNode()))
+          dyn_cast<LoadSDNode>(Res.getOperand(BigEndian ? 1 : 0).getNode()))
         if (FrameIndexSDNode *FI =
----------------
can you factor the ternary operator out into the definition of `BigEndian`?


================
Comment at: test/CodeGen/PowerPC/debuginfo-stackarg.ll:1
+; RUN: llc < %s -O1 -o - | FileCheck %s
+
----------------
can this be further localized by adding stop-after=live-debug-values?


================
Comment at: test/CodeGen/PowerPC/debuginfo-stackarg.ll:45
+
+attributes #0 = { nounwind readnone ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-features"="-altivec,-bpermd,-crypto,-direct-move,-extdiv,-htm,-power8-vector,-power9-vector,-qpx,-vsx" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind readnone speculatable }
----------------
please strip all non-essential attributes (everything in quotes?)


https://reviews.llvm.org/D37740