[PATCH] D34887: [mips] Implement the 'dext' aliases and it's disassembly alias.

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added inline comments.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:4924
+    const signed Size = Inst.getOperand(3).getImm();
+    if ((0 > (Pos + Size)) || ((Pos + Size) > 64))
+      return Match_RequiresPosSizeUImm6;
----------------
The error message says "size plus position are not in the range 1 .. 63" but if `Pos + Size` is equal to 0 or 64 this condition is `false` and we do not show the message. Should we synchronize the condition and the error message?


Repository:
  rL LLVM

https://reviews.llvm.org/D34887