[PATCH] D37412: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.

LGTM as well, with a couple of minors.



================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:589
+          return false;
+        }
+      // Treat a symbolic constant like an integer
----------------
RKSimon wrote:
> ```
> if (IDInfo.isKind(InlineAsmIdentifierInfo::EnumValKind))
>   return onInteger(IDInfo.Enum.EnumVal, ErrMsg);
> ```
This tidyup would still be nice.


================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:595
+        return false;
+      }
       PrevState = State;
----------------
RKSimon wrote:
> ```
> // Treat a symbolic constant like an integer
> if (auto *CE = dyn_cast<MCConstantExpr>(SymRef))
>   return onInteger(CE->getValue(), ErrMsg);
> ```
This tidyup would still be nice.


Repository:
  rL LLVM

https://reviews.llvm.org/D37412