[PATCH] D37724: [ARM] Add more CPUs to host detection

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

Hi Eli,

Thanks for adding this.
I expect you to have a much better understanding of Kryo cores, so I can't add much comments on the specific constants you added in the code for those.
For Cortex-A73, the constants in this patch seem incorrect, looking at the Cortex-A73 TRM, see my detailed comments.

Thanks!

Kristof



================
Comment at: lib/Support/Host.cpp:211
             .Case("0x205", "kryo")
+            .Case("0x211", "kryo")
+            .Case("0x800", "cortex-a73")
----------------
The summary of this patch states returning cortex-a73 for second-generation Kryo, but this patch also introduces returning "kryo" for "0x211". Just checking if this was intentional.


================
Comment at: unittests/Support/Host.cpp:108-110
+  EXPECT_EQ(sys::detail::getHostCPUNameForARM("CPU implementer : 0x51\n"
+                                              "CPU part        : 0x800"),
+            "cortex-a73");
----------------
I don't have easy access to a Cortex-A73 system at the moment, but I'd expect the CPU implementer for a Cortex-A73 be 0x41, the same as for other Arm-designed cores.
Also, according to http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.100048_0002_05_en/jfa1406793219362.html, the part number of Cortex-A73 is 0xD09, not 0x800.


Repository:
  rL LLVM

https://reviews.llvm.org/D37724