[lld] Small patch to ignore "/natvis:..." flag in the COFF / lld-link.exe frontend.

[Michael Rickert via llvm-commits]

Much appreciated!

From: Rui Ueyama [mailto:ruiu at google.com]
Sent: Monday, September 11, 2017 3:24 PM
To: Shoaib Meenai <smeenai at fb.com>
Cc: Michael Rickert <mike at maulingmonkey.com>; llvm-commits at lists.llvm.org
Subject: Re: [lld] Small patch to ignore "/natvis:..." flag in the COFF / lld-link.exe frontend.

LGTM

I'll commit it for you.

On Mon, Sep 11, 2017 at 1:48 PM, Shoaib Meenai <smeenai at fb.com<mailto:smeenai at fb.com>> wrote:
CCing Rui.

In my experience, patches usually get more visibility if you upload them to Phabricator.

From: llvm-commits <llvm-commits-bounces at lists.llvm.org<mailto:llvm-commits-bounces at lists.llvm.org>> on behalf of Michael Rickert via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>>
Reply-To: Michael Rickert <mike at maulingmonkey.com<mailto:mike at maulingmonkey.com>>
Date: Sunday, September 10, 2017 at 7:49 PM
To: "llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>" <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>>
Subject: [lld] Small patch to ignore "/natvis:..." flag in the COFF / lld-link.exe frontend.

MSVC’s link.exe supports an undocumented flag, /natvis:path/to/a/file.natvis, which will embed natvis files into generated pdbs – useful for dealing with multiple versions and ease of use when debugging (no IDE setup required!)

The attached patch simply makes LLVM’s lld-link.exe ignore this flag for now, fixing a recent rustc regression of mine:  https://github.com/rust-lang/rust/pull/43221#issuecomment-328276585 .  I intend to add a “temporary” workaround on rustc’s end as well.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170912/11a268fc/attachment.html>