[PATCH] D35089: Add/Implement AddresSpace to PseudoSourceValue.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/CodeGen/PseudoSourceValue.cpp:30
+    : Kind(Kind) {
+  assert(TII != nullptr);
+  AddressSpace = TII->getAddressSpaceForPseudoSourceKind(Kind);
----------------
I don't understand this response. Can you make this a reference? It seems required here in the constructor.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.h:261
 
+  unsigned getAddressSpaceForPseudoSourceKind(PseudoSourceValue::PSVKind Kind) const;
+
----------------
Line is too long.


https://reviews.llvm.org/D35089