[PATCH] D37718: [ELF] Handle references to garbage collected common symbols

[ben via Phabricator via llvm-commits]

bd1976llvm added a comment.

In https://reviews.llvm.org/D37718#867427, @bd1976llvm wrote:

> In https://reviews.llvm.org/D37718#867246, @ruiu wrote:
>
> > I don't remember why we don't have this check in getSymVA() for DefinedRegularKind. Should we actually be returning 0 for DefinedRegular if sections are dead too?
>
>
> Definitely.  I also think that we should change the code to treat regular and common symbols in the same way when it is possible.


I have a patch for what you are suggesting - is it ok to get this patch in first and put the improvements in as a later patch?


https://reviews.llvm.org/D37718