[llvm] r312756 - [llvm-objcopy] Add support for special section indexes in symbol table greater than SHN_LORESERVE

[Jake Ehrlich via llvm-commits]

I'll go ahead and add a check for e_machine==EM_HEXAGON then. Now that
Rafael and Roland point it out, that should be a check. Hopefully this
doesn't get too hairy to support all these architectures.

On Mon, Sep 11, 2017 at 4:45 PM Roland McGrath <mcgrathr at google.com> wrote:

> I don't personally care about any targets that use machine-specific or
> OS-specific st_shndx values, so just SHN_ABS and SHN_COMMON is fine.
>
> It's certainly the case that SHN_HEXAGON_SCOMMON* can be safely treated the
> same as SHN_COMMON.  But to be pedantic, you need to check that
> e_machine==EM_HEXAGON before assuming those [SHN_LOPROC,SHN_HIPROC] values
> have that particular meaning.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170911/bf7992a0/attachment.html>