[PATCH] D37714: llvm-dwarfdump: Replace -debug-dump=sect option with individual options.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Decided it wasn't worth keeping the old syntax? I think that's probably fine (looks like Nico added it inspired by the readelf syntax (which supports exactly that, --debug-dump=foo) - but since it's in a different binary anyway, I doubt anyone's using it for compatibility in scripts, etc).

Worth adding a test for the new "can dump more than one section" functionality?



================
Comment at: include/llvm/DebugInfo/DIContext.h:115-124
+namespace {
+/// This is just a helper to programmatically construct DIDumpType.
+enum DIDumpTypeCounter {
+  DIDT_ID_Null = 0,
+#define HANDLE_DWARF_SECTION(ENUM_NAME, ELF_NAME, CMDLINE_NAME) \
+  DIDT_ID##ENUM_NAME,
+#include "llvm/BinaryFormat/Dwarf.def"
----------------
Anonymous namespaces in headers are generally a bit suspect - tend to create ODR violations.




Repository:
  rL LLVM

https://reviews.llvm.org/D37714