[PATCH] D37408: LowerTypeTests: Add import/export support for targets without absolute symbol constants.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:497
+  uint8_t BitMask = 0;
+  uint64_t InlineBits = 0;
 };
----------------
Add comments for these new fields.


================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:815
+  auto ImportConstant = [&](StringRef Name, uint64_t Const, unsigned AbsWidth,
+                            IntegerType *IntTy) {
+    if (!shouldExportConstantsAsAbsoluteSymbols()) {
----------------
Comment that IntTy==nullptr means we actually want Int8PtrTy.
Maybe change the function to accept Type*, and do ptrcast if it is a PointerType, and create a ConstantInt directly if it is an IntegerType?



https://reviews.llvm.org/D37408