[PATCH] D37709: [MinGW] Add support for the options --[no-]whole-archive

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 14:17:13 PDT 2017


pcc added inline comments.


================
Comment at: COFF/Options.td:99-100
 
+def whole_archive : F<"whole-archive">;
+def no_whole_archive : F<"no-whole-archive">;
+
----------------
ruiu wrote:
> Since they are lld-specific flags, I'd name -lld-whole-archive and -lld-no-whole-archive.
I don't think you need to add lld-specific flags to support `--whole-archive`. Instead, you could implement support for the equivalent link.exe flag, `/wholearchive`. See also PR31824.


https://reviews.llvm.org/D37709





More information about the llvm-commits mailing list