[PATCH] D37708: Simplify MinGW test.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 11 14:03:37 PDT 2017
mstorsjo added inline comments.
================
Comment at: lld/test/MinGW/driver.s:2
# REQEUIRES: x86
-# RUN: rm -f a.exe a.dll
-
# RUN: llvm-mc -triple=x86_64-windows-msvc %s -filetype=obj -o %t.obj
+
----------------
Is there any value in actually assembling an input object for this test, when we actually don't do any real linking here?
================
Comment at: lld/test/MinGW/driver.s:33
+# RUN: ld.lld -### %t.obj -m i386pep --out-implib foo | FileCheck -check-prefix=STACK %s
+# STACK: -implib:foo
+
----------------
This test seems to have been mixed up, and I can't find the actual test for the stack option.
https://reviews.llvm.org/D37708
More information about the llvm-commits
mailing list