[PATCH] D37699: Improve readability of MinGW driver. NFC.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 13:01:45 PDT 2017


pcc added inline comments.


================
Comment at: lld/MinGW/Driver.cpp:176
+  for (auto *A : Args.filtered(OPT_l))
+    Add(searchLibrary(A->getValue(), SearchPaths, Args.hasArg(OPT_Bstatic)));
 
----------------
It looks like you are changing the link order; now all non-`-l` inputs will appear before `-l` inputs. I don't think this should matter except in some edge cases, but it would at least mean that this change is not NFC.


https://reviews.llvm.org/D37699





More information about the llvm-commits mailing list