[PATCH] D37696: [dwarfdump] Add DWARF verifiers for address ranges

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Seems generally good. Since David had a lot of comments on the original review, I'll defer to him to accept this.



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFVerifier.h:60
+    ///
+    /// This is used for finding overlapping ranges within the same DIE.
+    address_range_iterator insert(const DWARFAddressRange &R);
----------------
does this comment belong to the next function?


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFVerifier.h:83
+    // RHS.
+    bool intersects(const DieRangeInfo &RHS) const;
+  };
----------------
`///`


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:61
+bool DWARFVerifier::DieRangeInfo::contains(const DieRangeInfo &RHS) const {
+  // Both list of ranges are sorted so we can make this fasts
+
----------------
`s/fasts/fast./`


Repository:
  rL LLVM

https://reviews.llvm.org/D37696