[PATCH] D37686: [DAG] Consolidating Instruction->SDNode Flags propagation in one class for better code management.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 08:01:02 PDT 2017


RKSimon added a comment.

In https://reviews.llvm.org/D37686#866495, @jbhateja wrote:

> @RkSimon Anything else or should I  check this in as NFC.


@spatel needs to review



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6600
 void SelectionDAGBuilder::visitCall(const CallInst &I) {
+
   // Handle inline assembly differently.
----------------
remove newline diff


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:666
+  // a given Value.
+  SDNode * getDAGNode(const Value *);
+
----------------
is this needed in this patch?


https://reviews.llvm.org/D37686





More information about the llvm-commits mailing list