[PATCH] D34816: [GlobalISel][X86] support G_FPEXT operation.

[Igor Breger via Phabricator via llvm-commits]

igorb added inline comments.


================
Comment at: lib/Target/X86/X86RegisterBankInfo.cpp:196
+  default:
+    // Track the bank of each register, use NotFP mapping (all scalars in GPRs)
+    getInstrPartialMappingIdxs(MI, MRI, /* isFP */ false, OpRegBankIdx);
----------------
guyblank wrote:
> move comment up + update it? 
> 
> consider moving the switch to a helper  
> 
> ```
> getInstrPartialMappingIdxs(MI, MRI, isFP(Opc), OpRegBankIdx);
> ```
For now i prefer not to move the logic to help function.


https://reviews.llvm.org/D34816