[PATCH] D37683: [mips] Correcting operand range for DINSM instruction

Aleksandar Beserminji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 05:59:45 PDT 2017


abeserminji created this revision.
Herald added a subscriber: arichardson.

This patch corrects the definition of the DINSM instruction. Specification for DINSM instruction for Mips64 says that size operand should be //2 <= size <= 64//, but it is defined as //uimm5_inssize_plus1// which gives range of 1 .. 32.


Repository:
  rL LLVM

https://reviews.llvm.org/D37683

Files:
  lib/Target/Mips/Mips64InstrInfo.td


Index: lib/Target/Mips/Mips64InstrInfo.td
===================================================================
--- lib/Target/Mips/Mips64InstrInfo.td
+++ lib/Target/Mips/Mips64InstrInfo.td
@@ -331,7 +331,7 @@
              EXT_FM<7>, ISA_MIPS64R2;
   def DINSU : InsBase<"dinsu", GPR64Opnd, uimm5_plus32, uimm5_inssize_plus1>,
               EXT_FM<6>, ISA_MIPS64R2;
-  def DINSM : InsBase<"dinsm", GPR64Opnd, uimm5, uimm5_inssize_plus1>,
+  def DINSM : InsBase<"dinsm", GPR64Opnd, uimm5, uimm_range_2_64>,
               EXT_FM<5>, ISA_MIPS64R2;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37683.114577.patch
Type: text/x-patch
Size: 551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170911/b7366412/attachment.bin>


More information about the llvm-commits mailing list