[PATCH] D29933: [RISCV 11/n] Initial codegen support for ALU operations

[Pavel Šnobl via Phabricator via llvm-commits]

psnobl added inline comments.


================
Comment at: lib/Target/RISCV/RISCVCallingConv.td:15
+// RISCV 32-bit C return-value convention.
+def RetCC_RISCV32 : CallingConv<[CCIfType<[i32], CCAssignToReg<[X10_32, X11_32]>>]>;
+
----------------
Shouldn't there also be promotion of i8/i16 values to i32 (similar to the argument passing below)?


================
Comment at: lib/Target/RISCV/RISCVISelDAGToDAG.cpp:46
+  // Dump information about the Node being selected.
+  DEBUG(errs() << "Selecting: "; Node->dump(CurDAG); errs() << "\n");
+
----------------
You sometimes use errs() and sometimes dbgs() for these debug printouts. This should be unified to dbgs().


https://reviews.llvm.org/D29933