[PATCH] D36870: [libcxx] Add missing __cxa_deleted_virtual

[Stephan Bergmann via Phabricator via llvm-commits]

sberg added inline comments.


================
Comment at: lib/abi/x86_64-unknown-linux-gnu.abilist:1873
 {'is_defined': False, 'name': '__cxa_decrement_exception_refcount', 'type': 'FUNC'}
+{'is_defined': False, 'name': '__cxa_deleted_virtual', 'type': 'FUNC'}
 {'is_defined': False, 'name': '__cxa_end_catch', 'type': 'FUNC'}
----------------
EricWF wrote:
> Why are we changing the Linux lists when this change only affects OS X?
As I wrote, "I have no real idea what all these various files are used for, and which changes exactly are required and correct. Just adding __cxa_deleted_virtual to all files in libcxx that already mentioned __cxa_pure_virtual [...]"  The  way libc++.so on Linux consists of
```
INPUT(libc++.so.1 -lc++abi)
```
it does not need the fix that macOS needs to make __cxa_deleted_virtual available through -lc++, but it still "re-exports" __cxa_deleted_virtual the same way it does for __cxa_pure_virtual (which is also mentioned in this file), so I naively assumed it should be listed here, too.


https://reviews.llvm.org/D36870