[PATCH] D37675: [GlobalISel][X86] G_ANYEXT support.

Elena Demikhovsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 01:46:33 PDT 2017


delena accepted this revision.
delena added a comment.
This revision is now accepted and ready to land.

LGTM, + replace "if"s with "assert"s



================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:743
+
+  if (DstRB.getID() != SrcRB.getID()) {
+    DEBUG(dbgs() << "G_ANYEXT input/output on different banks\n");
----------------
I assume that source and dest should be always from the same reg bank. If yes, please put "assert" here. If no, please add a comment in what case it is not handled.


================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:749
+  if (DstRB.getID() != X86::GPRRegBankID ||
+      DstTy.getSizeInBits() < SrcTy.getSizeInBits())
+    return false;
----------------
sizeinbits of AnyExt should be checked on IR level.


https://reviews.llvm.org/D37675





More information about the llvm-commits mailing list