[PATCH] D33880: COFF: Introduce LD shim around LINK

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 10 12:57:22 PDT 2017


martell added a comment.

@mstorsjo I had actually done a bunch of these tests but as separate files yesterday.
Given that it is just a wrapper having just output.test probably makes more sense here.

I was actually looking through tests/COFF wondering what would be the best test for the __image_base__ test.
Thanks for the help there.

the x64 test did not actually check the IMAGE_FILE_MACHINE_AMD64 so I added that.
also I wanted to add a test to ensure that __ImageBase is still supported because long term I want binutils to use that also so we can use LINK.exe with mingw-w64 if needed.
So for that I added an arm and aarch64 test that uses __ImageBase instead, so we can check that and thimb2pe and arm64pe all in the one test.


Repository:
  rL LLVM

https://reviews.llvm.org/D33880





More information about the llvm-commits mailing list