[PATCH] D37579: [InstCombine] Fix PR21780 Expansion of 256 bit vector loads fails to fold into shuffles
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 10 03:42:26 PDT 2017
RKSimon added a comment.
Some style comments as the poor bracing/indentation makes it difficult to grok - more thorough review needs to wait until you've addressed @hfinkel's comments on https://reviews.llvm.org/D37648 about phantom mem intrinsics
================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1477
+ }
+ }
+
----------------
clang-format this - your indentation is broken.
================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:2931
+ }
+}
+
----------------
clang-format - braces and indentation are really bad
https://reviews.llvm.org/D37579
More information about the llvm-commits
mailing list