[PATCH] D37547: [X86] Call removeDeadNode when we're done doing custom isel for mul, div and test

[Nirav Dave via Phabricator via llvm-commits]

niravd accepted this revision.
niravd added a comment.
This revision is now accepted and ready to land.

Yet another case of unused nodes being left behind and causing degradation. We should change the behavior of the DAG ReplaceAllUses-ish functions to check if the old source node becomes unused and if so delete the node. This would obviate the need for this patch and catch the lion share of these sorts of issues but will cause assertions in cases a bunch of cases (which is a better situation than the current silent degradation). I have a first-cut patch (https://reviews.llvm.org/D36643) which fixes just the DAGCombiner CombineTo function and all of the assertion failures from update ordering / double deletions.

In any case, this LGTM.


https://reviews.llvm.org/D37547