[PATCH] D37652: Remove unneccessary string copies from method invocations.

[Eugene Zelenko via Phabricator via llvm-commits]

Eugene.Zelenko added a comment.

Will be good idea to also run Clang-tidy modernize-* over this code.



================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:432
 public:
   virtual ~SourcePrinter() {}
   SourcePrinter() : Obj(nullptr), Symbolizer(nullptr) {}
----------------
Please use = default and move it after constructors.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:433
   virtual ~SourcePrinter() {}
   SourcePrinter() : Obj(nullptr), Symbolizer(nullptr) {}
   SourcePrinter(const ObjectFile *Obj, StringRef DefaultArch) : Obj(Obj) {
----------------
Please use default member initialization and = default;


https://reviews.llvm.org/D37652