[PATCH] D37654: PPC: Don't select lxv/stxv for insufficiently aligned stack slots.
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 8 17:00:32 PDT 2017
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Couple inline comments, first should be handled, otherwise looks OK to me.
-eric
================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:3063
+ FrameIndexSDNode *FI = dyn_cast<FrameIndexSDNode>(AddrOp.getOperand(0));
+ if (FI) {
+ int Idx = FI->getIndex();
----------------
if (FrameIndexSDNode *FI = dyn_cast<....> ...) {
}
================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:3064-3066
+ int Idx = FI->getIndex();
+ const MachineFrameInfo &MFI = CurDAG->getMachineFunction().getFrameInfo();
+ unsigned SlotAlign = MFI.getObjectAlignment(Idx);
----------------
Can probably merge some of the single use variables here, but I also don't mind if you want to keep them :)
Repository:
rL LLVM
https://reviews.llvm.org/D37654
More information about the llvm-commits
mailing list