[PATCH] D37563: Convenience/safety fix for llvm::sys::Execute(And|No)Wait

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:460
   ArgsV.push_back(nullptr);
-  StringRef InputPathRef = InputPath.str();
-  StringRef OutputPathRef = OutputPath.str();
-  StringRef StderrRef;
-  const StringRef *Redirects[] = {&InputPathRef, &OutputPathRef, &StderrRef};
+  Optional<StringRef> Redirects[] = {InputPath.str(), OutputPath.str(), {""}};
   std::string ErrMsg;
----------------
vsk wrote:
> You've used llvm::None for the stderr redirect, and I think it would be clearer / more consistent to use llvm::None here too.
Sorry, I meant to write: 'you've used None stderr redirect earlier in lib/Support/Signals.cpp'. I'm not sure what the difference is here.


https://reviews.llvm.org/D37563