[llvm] r312834 - [TargetTransformInfo] Remove the extra "default" in a switch that all enum values has been covered.

Guozhi Wei via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 16:34:28 PDT 2017


Author: carrot
Date: Fri Sep  8 16:34:28 2017
New Revision: 312834

URL: http://llvm.org/viewvc/llvm-project?rev=312834&view=rev
Log:
[TargetTransformInfo] Remove the extra "default" in a switch that all enum values has been covered.

In function TargetTransformInfo::getInstructionCost, all enum values in the switch statement has been covered, so the default is unnecessary, and may cause error with option -Werror,-Wcovered-switch-default, so remove it.


Modified:
    llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h

Modified: llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h?rev=312834&r1=312833&r2=312834&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h (original)
+++ llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h Fri Sep  8 16:34:28 2017
@@ -141,11 +141,9 @@ public:
 
     case TCK_CodeSize:
       return getUserCost(I);
-
-    default:
-      llvm_unreachable("Unknown instruction cost kind");
-      return 0;
     }
+
+    return 0;
   }
 
   /// \brief Underlying constants for 'cost' values in this interface.




More information about the llvm-commits mailing list