[PATCH] D37616: [X86] PR34149 Suboptimal codegen for fast minnum and maxnum.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

The way you're transferring the flags from the IR to the node works for this particular case, but I'd prefer that we clean that up as a preliminary step for this patch if possible. The existing flags transfer code is limited because we started with SDNodeFlags only on binary operators. So there's a different blob of code to handle flags in SelectionDAGBuilder::visitBinary(). Can we unify that? Is it possible to handle this for all opcodes/nodes in SelectionDAGBuilder::visit()?


https://reviews.llvm.org/D37616