[PATCH] D37637: [CMake] Determine early on which projects are enabled

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

compiler-rt changes look great!



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:929
+      continue()
+    elseif(EXISTS "${LLVM_EXTERNAL_${projUPPER}_SOURCE_DIR}")
+      set(LLVM_PROJECT_${projUPPER}_ENABLED ON)
----------------
The code in llvm/projects treats any subdirectory with CMakeLists.txt as a project. Could we do the same here, instead of listing all (or some?) known projects?



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:932
+      set(LLVM_PROJECT_${projUPPER}_SOURCE_DIR "${LLVM_EXTERNAL_${projUPPER}_SOURCE_DIR}")
+    elseif(EXISTS "${base_dir}/${proj}")
+      set(LLVM_PROJECT_${projUPPER}_ENABLED ON)
----------------
Might be a good idea to warn if a project is found in two places at once.



https://reviews.llvm.org/D37637