[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 13:47:31 PDT 2017


aprantl added a comment.

In https://reviews.llvm.org/D37602#865266, @zturner wrote:

> I think this addresses most of the concerns raised so far.


Here's a couple of concerns that were mentioned before that are outstanding:

- The Readme.txt needs to be updated, it currently states that the repository is supposed to be cloned into tools/clang/test.
- The clang lit configuration needs to be updated to remove the debuginfo-tests-specific parts.
- This patch is adding >300 lines of extra configuration. I still don't understand what problem this patch is solving that is worth the extra maintenance effort.


https://reviews.llvm.org/D37602





More information about the llvm-commits mailing list