[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 114422.
zturner added a reviewer: chandlerc.
zturner added a comment.
Herald added a reviewer: modocache.

I think this addresses most of the concerns raised so far.  The logic to conditionally add a dependency on CMake depends on https://reviews.llvm.org/D37637.  I took rnk's advice and looked at what compiler-rt is doing, and was a little bit horrified.  I can always go back to that if needed, but I decided to generalize what compiler-rt was doing and add it to LLVM's main CMake library instead, and then build off of that.  I think it makes for cleaner / more easily understandable code this way.

I also talked with rnk about how to mitigate the effects of the code duplication.  He can correct me if I'm misrepresenting him, but I believe we both came to the agreement that this duplication is something that has been ongoing with LLVM's lit infrastructure and configuration files for some time.  That said, we both agreed that it should be possible to move a lot of this functionality into the core lit utility library.  I think that's a good improvement which I'm willing to attempt in a follow-up.

In any case, +chandlerc because it seems like the # of people who understand this lit stuff is pretty small, so hopefully this elicits some additional feedback.


https://reviews.llvm.org/D37602

Files:
  debuginfo-tests/CMakeLists.txt
  debuginfo-tests/lit.cfg
  debuginfo-tests/lit.site.cfg.in
  llvm/CMakeLists.txt
  llvm/projects/CMakeLists.txt
  llvm/utils/lit/lit/util.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37602.114422.patch
Type: text/x-patch
Size: 17010 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170908/b5d754bf/attachment.bin>