[PATCH] D37628: Cleanup: Merge isKnownNonNull into isKnownNonZero

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Analysis/ValueTracking.cpp:1752
 
+static bool isKnownNonNullFromDominatingCondition(const Value *V,
+                                                  const Instruction *CtxI,
----------------
Should we rename this also to be isKnownNonZeroFromDominatingCondition?


================
Comment at: lib/Analysis/ValueTracking.cpp:1849
 
-    return false;
+     // A global variable in address space 0 is non null unless extern weak
+    // or an absolute symbol reference. Other address spaces may have null as a
----------------
Indentation is off on this line.


Repository:
  rL LLVM

https://reviews.llvm.org/D37628