[PATCH] D36579: [ELF] - Do not fail when set versions for linkerscript's symbol aliases

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:1028
+      if (Cmd->Name != "." && !Symtab->find(Cmd->Name) && !Cmd->Provide)
+        Symtab->addAbsolute<ELFT>(Cmd->Name, STV_DEFAULT, STB_WEAK);
+
----------------
grimar wrote:
> ruiu wrote:
> > Is there any reason to create symbols as STB_WEAK?
> Yes, please refer to my comment above:
> https://reviews.llvm.org/D36579#861990
I don't think adding symbols as weak symbols is a right thing to do, if the problem is just for _gp. It implies that _gp's handling is not right.


https://reviews.llvm.org/D36579