[PATCH] D37625: [DWARF] Incorrect prologue end line record.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I think the argument (and the test) would be stronger if it was based on the instruction sequence rather than offsets.  For example if you generate asm and then show prologue_end is immediately before the call to get_arg.
Also we generally like to trim the IR source by removing unnecessary attribute sets.

I'm actually more curious why part of the prologue is associated with line 5 and part with line 7.  That feels like there's some pass mis-handling debug locations, and it would be preferable to find that rather than have DwarfDebug cover it up.


https://reviews.llvm.org/D37625