[PATCH] D37615: [AVR] implement the relocation of LDI for LLD

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/AVR.cpp:73
+  case R_AVR_LDI: {
+    write<uint8_t, little>(Loc, read<uint8_t, little>(Loc) + Val);
+    break;
----------------
`read<uint8_t>` or `write<uint8_t>` don't make sense because byte order doesn't matter if you read or write a single byte.


================
Comment at: ELF/Arch/AVR.cpp:84
   default:
-    error(getErrorLocation(Loc) + "unrecognized reloc " + toString(Type));
+    error(getErrorLocation(Loc) + "unrecognized reloc " + Twine(Type));
   }
----------------
Why did you change this?


Repository:
  rL LLVM

https://reviews.llvm.org/D37615