[PATCH] D37256: [Nios2] adding subtarget, basic infrastructure for frame, instructions and registers

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/Nios2/Nios2RegisterInfo.cpp:35
+Nios2RegisterInfo::getCalleeSavedRegs(const MachineFunction *MF) const {
+  return NULL;
+}
----------------
Use nullptr instead of NULL


================
Comment at: llvm/lib/Target/Nios2/Nios2Subtarget.cpp:45
+  if (TargetTriple.getArch() == Triple::nios2) {
+    if (CPU.empty() || CPU == "generic") {
+      CPU = "nios2r1";
----------------
This doesn't look like what other targets do. I don't see any other target looking for "help".


https://reviews.llvm.org/D37256