[PATCH] D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals

[Peter Smith via Phabricator via llvm-commits]

peter.smith updated this revision to Diff 114370.
peter.smith added a comment.

Thanks very much for the comments. Yes you are correct that the ThunkSpacing could be increased to ~32Mb after the first one, however I thought I'd try and keep it simple for the first iteration.

I've incorporated your suggestions into createInitialThunkSections(), in summary:

- I've removed PrevISR and moved to storing the previous insertion point, this removes the need for the conditional expression.
- I've renamed Off, Limit in favour of ISLimit and ThunkUpperBound, I'm hoping that this makes the intent clearer.
- I've removed the NeedsTrailingTS as it doesn't hurt to just add the trailing InputSection anyway as we'll just remove it if it isn't used.


https://reviews.llvm.org/D34689

Files:
  ELF/Arch/ARM.cpp
  ELF/Relocations.cpp
  ELF/Relocations.h
  ELF/SyntheticSections.cpp
  ELF/Target.h
  test/ELF/arm-thumb-thunk-symbols.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34689.114370.patch
Type: text/x-patch
Size: 13736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170908/69fd5679/attachment.bin>