[PATCH] D33960: ErrorHandling: report_fatal_error: call abort() instead of exit()

[Reid Kleckner via Phabricator via llvm-commits]

rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.

I'm not sure this is a good idea. For years, report_fatal_error outside clang hasn't printed a stack trace or a banner, and that's intentional behavior.

I think the question is, is a report_fatal_error exit indicative of a bug, or is it possibly working as intended? For a long time we've treated it as a valid (but lazy and crappy) way to handle errors in library code. Are we changing that? I could be OK with that as long as its announced. If we want to do this, we should announce it as a new direction for the project on llvm-dev.


Repository:
  rL LLVM

https://reviews.llvm.org/D33960