[PATCH] D37467: Add a new pass to speculate around PHI nodes with constant (integer) operands when profitable.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D37467#861195, @davidxl wrote:

> Just some initial comments around the test cases.
>
> It seems that all test cases are testing non speculative code hoisting -- there are no speculative hoisting tests.


Sorry, I can add some non-hoisted code as well, for example a call that may not return. That's the way in which this is technically speculation.

But I agree "speculation" is perhaps a frustrating term here. I'm using it only because a very similar transform in SROA where loads are lifted around PHI operands is called "speculating" and so it seemed the least bad term I knew of... That said, if there is a better term, I'm happy to switch to it.


https://reviews.llvm.org/D37467