[PATCH] D37570: [XRay][CodeGen][PowerPC] Fix tail exit codegen for XRay in PPC

[Dean Michael Berris via Phabricator via llvm-commits]

dberris marked an inline comment as done.
dberris added inline comments.


================
Comment at: lib/CodeGen/XRayInstrumentation.cpp:118
-      }
-      if (TII->isTailCall(T)) {
-        Opc = TargetOpcode::PATCHABLE_TAIL_CALL;
----------------
timshen wrote:
> dberris wrote:
> > timshen wrote:
> > > This is actively removing PATCHABLE_TAIL_CALL emits, and it affects all architectures.
> > > 
> > > Can we add x86 tests for tracking the decisions we've made?
> > Note that this function only gets called for non-X86 architectures (where prepending is the correct solution).
> > 
> > We already have tests in X86 for the tail call exit sled lowering. Those pass with this change.
> We have other non-x86 targets like aarch64, right? How do those targets test this?
Yes, we have the following tests aside from the ones we're adding here.

```
test/CodeGen/ARM/xray-tail-call-sled.ll
test/CodeGen/AArch64/xray-tail-call-sled.ll
```

Or did you mean we need a test for tail calls out to hidden/external functions?


https://reviews.llvm.org/D37570