[PATCH] D37528: [JumpThreading] Preserve dominance across the pass.

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 17:47:30 PDT 2017


kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

LGTM after the fixes, but you may want to wait for a green light from someone else.



================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:678
   // become the entry block after we erase PredBB.
-  if (PredBB == &DestBB->getParent()->getEntryBlock())
+  bool replacedEntryBB = false;
+  if (PredBB == &DestBB->getParent()->getEntryBlock()) {
----------------
nit: `s/replaceEntryBB/ReplaceEntryBB`


https://reviews.llvm.org/D37528





More information about the llvm-commits mailing list