[PATCH] D37607: COFF: Implement ThinLTO cache and cache pruning support.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/docs/ThinLTO.rst:128
   ``-Wl,--thinlto-cache-dir=/path/to/cache``
+- COFF lld (as of LLVM trunk):
+  ``/lldltocache:/path/to/cache``
----------------
Is "as of LLVM 6.0" better?


================
Comment at: lld/COFF/Driver.cpp:880
 
+  if (auto *Arg = Args.getLastArg(OPT_lldltocache))
+    Config->LTOCache = Arg->getValue();
----------------
Just like other pieces of code, I'd add

  // Handle /lldltocache

It might be a bit too verbose, but I'd keep it consistent.


================
Comment at: lld/COFF/Driver.cpp:883
+
+  if (auto *Arg = Args.getLastArg(OPT_lldltocachepolicy)) {
+    Config->LTOCachePolicy = check(
----------------
nit: you don't need {}


https://reviews.llvm.org/D37607