[PATCH] D37570: [XRay][CodeGen][PowerPC] Fix tail exit codegen for XRay in PPC

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 17:25:54 PDT 2017


dberris marked an inline comment as done.
dberris added inline comments.


================
Comment at: lib/CodeGen/XRayInstrumentation.cpp:118
-      }
-      if (TII->isTailCall(T)) {
-        Opc = TargetOpcode::PATCHABLE_TAIL_CALL;
----------------
timshen wrote:
> This is actively removing PATCHABLE_TAIL_CALL emits, and it affects all architectures.
> 
> Can we add x86 tests for tracking the decisions we've made?
Note that this function only gets called for non-X86 architectures (where prepending is the correct solution).

We already have tests in X86 for the tail call exit sled lowering. Those pass with this change.


https://reviews.llvm.org/D37570





More information about the llvm-commits mailing list