[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: debuginfo-tests/CMakeLists.txt:22
+  clang
+  lld
+  llvm-config
----------------
zturner wrote:
> rnk wrote:
> > aprantl wrote:
> > > why does it need lld? Shouldn't the system linker be good enough?
> > Don't make this unconditional, do it like ASan does: add the dependency iff LLD is checked out. See how compiler-rt tests for it. We can feed lld's existence as a variable into the test suite. Besides, LLD doesn't have a functioning MachO port today. We need to disable any LLD-depending tests on Darwin.
> No, lld is a hard requirement.  Part of what we're trying to do is test that we emit PDBs that can work with Microsoft tools.  If we use the system linker, that defeats the entire purpose.
> 
> As an aside, "system linker" on Windows isn't really a thing, since systems don't really //have// linkers unless you install them. Which in this case would be MSVC's linker, which we already know works for obvious reasons
Don't see why lld is a "hard requirement."  Surely you want clang's concept of CodeView output to work with the MSVC linker as well as with lld.  Or is clang-cl no longer viewed as a drop-in replacement for cl?


================
Comment at: debuginfo-tests/lit.cfg:289
+if config.host_triple == config.target_triple:
+    config.available_features.add("native")
+
----------------
See D37604.


https://reviews.llvm.org/D37602