[PATCH] D20217: Add direct control of whether or not a symbol is preemtable at runtime

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

This should update LangRef with a description of how this is supposed to interact with our existing linkages. For example, today we can inline external function definitions because they are not interposable according to our model. LLVM basically implements the C++ model: multiple definitions of an external linkage function would be an ODR violation, widespread usage of malloc interposition notwithstanding. You seem to be proposing to change that, because dso_local defaults to false. dso_preemptible seems to be your default. Why did you remote the old tri-state dso storage in the latest patch? It seems like we could use the third state to preserve our existing behavior unless the frontend tells us otherwise.



================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:926
 
+
 static int getDecodedCastOpcode(unsigned Val) {
----------------
Unnecessary whitespace change


Repository:
  rL LLVM

https://reviews.llvm.org/D20217